-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli/command: deprecate CopyToFile and reimplement with atomicwriter #5914
Draft
thaJeztah
wants to merge
6
commits into
docker:master
Choose a base branch
from
thaJeztah:use_atomicwriter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5914 +/- ##
===========================================
- Coverage 59.14% 44.44% -14.71%
===========================================
Files 355 6 -349
Lines 29738 261 -29477
===========================================
- Hits 17590 116 -17474
+ Misses 11173 139 -11034
+ Partials 975 6 -969 🚀 New features to boost your workflow:
|
5e6b61d
to
64a2e41
Compare
64a2e41
to
4a19b1a
Compare
This function was exported in e43c792 for use of "docker app", which is now deprecated. The signature of this function also depended on a non-exported type so it could not be used externally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function was exported in e43c792 for use of "docker app", which is now deprecated. The signature of this function also depended on a non-exported type, so it could not be used externally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function was exported in 812f113 for use in other parts of the CLI, but it's now only used locally. Make it internal again, as it was never designed to be exported. There are no known external consumers of this function, but deprecating it first, in case there are. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Same functionality, but implemented with atomicwriter. There's a slight difference in error-messages produced (but can be adjusted if we want). Before: docker image save -o ./no/such/foo busybox:latest failed to save image: invalid output path: directory "no/such" does not exist docker image save -o /no/permissions busybox:latest failed to save image: stat /no/permissions: permission denied After: docker image save -o ./no/such/foo busybox:latest failed to save image: invalid file path: stat no/such: no such file or directory docker image save -o /no/permissions busybox:latest failed to save image: failed to stat output path: lstat /no/permissions: permission denied Signed-off-by: Sebastiaan van Stijn <[email protected]>
Same functionality, but implemented with atomicwriter. There's a slight difference in error-messages produced (but can be adjusted if we want). Before: docker container export -o ./no/such/foo mycontainer failed to export container: invalid output path: directory "no/such" does not exist docker container export -o /no/permissions mycontainer failed to export container: stat /no/permissions: permission denied After: docker container export -o ./no/such/foo mycontainer failed to export container: invalid file path: stat no/such: no such file or directory docker container export -o /no/permissions mycontainer failed to export container: failed to stat output path: lstat /no/permissions: permission denied Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
4a19b1a
to
239e6ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)